[DebugInfo] Dont generate info for __swift_async_resume_project_conte… #75553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires swiftlang/llvm-project#9025 |
| @@ -2603,7 +2603,7 @@ llvm::Function *IRGenFunction::getOrCreateResumePrjFn(bool forPrologue) { | |||
| auto callerContext = IGF.emitAsyncResumeProjectContext(addr); | |||
| Builder.CreateRet(callerContext); | |||
| }, | |||
| false /*isNoInline*/, forPrologue)); | |||
| false /*isNoInline*/, true/*for prologue*/)); | |||
There was a problem hiding this comment.
Should we remove the forPrologue parameter from getOrCreateResumePrjFn?
There was a problem hiding this comment.
We can't, because this function is used in a ton of places, most of them with "for prologue" == false.
What it would be nice is to rename this parameter to something more meaningful like "skip debug info", since this is what this parameter does. The original patch mixed the motivation from call sites with the effect inside this function.
There was a problem hiding this comment.
Ah sorry I missed that this could be called for one of two async resume functions, and it uses forPrologue to pick the name.
…xt or __swift_async_resume_get_context These functions are alwaysinline and their instructions are created with line 0 as a location. As a result, the instructions all get inlined with line 0 into funclets. In practice, this makes it so that the first instruction of the funclet containing a debug location happens much later. This is important because the inlined instructions do meaningful work, like overwriting the contents of `fp - 8`. If we try to set a breakpoint into this funclet, we *must* break before these instructions, by allowing the line 0 locations to propagate, we fail to do. This patch changes this by removing all debug locations from the helper functions. By doing so, when they are inlined, instructions will inherit the location of the call site.
felipepiovezan
force-pushed
the
felipe/unwinding_pc_patches_swift
branch
from
f333324 to
768f391
Compare
|
Superseded by #75881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xt or __swift_async_resume_get_context
These functions just return their own parameter and are inlined. We don't want to see any debug information nor inlined frames for these when looking at async backtraces.
Not only is it a bad user experience, but these inlined frames are involved in tail calls in virtual backtraces, which thoroughly confuse the debugger.