[Caching] Use swift-frontend as executable name in replays
#75555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
changed the title
swift-frontend as exectuable name in replaysswift-frontend as executable name in replays
cachemeifyoucan
force-pushed
the
eng/PR-132758308
branch
from
997cd6e to
f973181
Compare
|
@swift-ci please smoke test |
Fix an assertion when replayDiagnostics failed in libSwiftScan.
Don't try to figure out the executable names during replay from libSwiftScan.dylib. The actual executable path for the process actually doesn't matter in this case to reconstruct the invocation and might actually be misleading. Just use `swift-frontend` as a placeheader executable name for in-process cache replay. rdar://132758308
cachemeifyoucan
force-pushed
the
eng/PR-132758308
branch
from
f973181 to
61e725f
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
Jul 30, 2024
|
@swift-ci please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to figure out the executable names during replay from
libSwiftScan.dylib. The actual executable path for the process actually
doesn't matter in this case to reconstruct the invocation and might
actually be misleading.
Just use
swift-frontendas a placeheader executable name forin-process cache replay.
rdar://132758308