Skip to content

[6.0][CMake] Enable package CMO only in newer compilers #75559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

[6.0][CMake] Enable package CMO only in newer compilers #75559

merged 1 commit into from
Jul 30, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 30, 2024 •
edited by bnbarham
Loading

Cherry-pick #75557

  • Explanation: Restricts enabling package CMO to only toolchains that properly support it to avoid linkage errors.
  • Scope: swift-syntax
  • Risk: Very low, disables package CMO in more cases
  • Testing: No extra tests, this is a build time issue
  • Issue: rdar://132708551
  • Reviewer: Ben Barham (@bnbarham)

@rintaro rintaro requested a review from a team as a code owner July 30, 2024 03:35
@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2024

@swift-ci Please test

@rintaro rintaro changed the title [CMake] Enable package CMO only in newer compilers [6.0][CMake] Enable package CMO only in newer compilers Jul 30, 2024
@bnbarham bnbarham enabled auto-merge July 30, 2024 03:38
@bnbarham bnbarham merged commit d9476aa into swiftlang:release/6.0 Jul 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham