Ensure Foundation tests don't run when passing --skip-foundation-tests #75573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
preset=linux_lldb |
|
@swift-ci please smoke test |
|
preset=linux_lldb |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
etcwilde
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Foundation's tests are defined as separate build script steps after SwiftPM, we need to ensure that the tests respect the
--skip-foundation-testsargument. Instead of passing it tobuild-script-impl, we capture it as an argument and use it to provide theshould_testvalue. This ensures that CI runs that don't test Foundation (because they don't build SwiftPM or otherwise) don't attempt to run Foundation tests.