[Concurrency] Flip the implicitly async select in a concurrency error.
#75578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
approved these changes
Jul 31, 2024
hborla
force-pushed
the
correct-implicit-async-diagnostic
branch
from
f686eaf to
ac96aee
Compare
|
@swift-ci please smoke test |
This diagnostic was presenting "implicitly async" for explicitly async calls, and vice versa, because the `select` was incorrect.
hborla
force-pushed
the
correct-implicit-async-diagnostic
branch
from
ac96aee to
d40663d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diagnostic was presenting "implicitly async" for explicitly async calls, and vice versa, because the
selectwas incorrect. The caller is passingapply->isImplicitlyAsync(), andtrueselects the second option.Resolves #74472