Skip to content

[Concurrency] Harden task group test which is sensitive to timing #75612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Aug 1, 2024

rdar://132887522

Pretty confident that this was a timing issue; we didn't see the task cancelled so the output wasn't the "cancelled path" which we're trying to test at all.

Giving this more leeway and debug output will help on very slow host machines.

@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Aug 1, 2024
@ktoso
Copy link
Contributor Author

ktoso commented Aug 1, 2024

@swift-ci please smoke test

@ktoso ktoso merged commit 9906199 into swiftlang:main Aug 1, 2024
3 checks passed
@ktoso ktoso deleted the wip-harden-taskgroupthrowingtest branch August 1, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant