[6.0][🍒] Avoid recursing into non swift modules when collecting exported imports #75621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Explanation: Ensures that symbol graph generation code doesn't look for transitive exported imports in non swift imported modules. Scope: Fix erroneous output or hangs during symbol graph generation. Risk: Low. This only affects symbol graph generation and not regular build or module emission. Original PR: #75619 Testing: Test suite contained existing tests which were modified to catch this regression. Issue/Radar: rdar://132593532 Reviewed By: @QuietMisdreavus |
tbkka
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid recursing into non swift modules when collecting exported imports
Original PR: #75619
rdar://132593532