[stdlib] fix some inconsistent declarations #75622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
glessard
force-pushed
the
rdar132941798-aEIC-private-consternation
branch
from
c157777 to
1f11eec
Compare
|
@swift-ci please smoke test |
`private` declarations should never be allowed to carry the `@_alwaysEmitIntoClient` attribute. This has been allowed by mistake for a while, but newer compilers should make this an error.
glessard
force-pushed
the
rdar132941798-aEIC-private-consternation
branch
from
1f11eec to
dd854fa
Compare
|
@swift-ci please test |
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privatefunction declarations should never be allowed to carry the@_alwaysEmitIntoClientattribute. This has been allowed by mistake for a while, but newer compilers should make this an error. The strange consequence of this combination of keywords was that theseprivatesymbols were emitted into the swiftinterface file.Also: opportunistically changed a
bindMemory()usage to use temporary rebinding instead.Addresses rdar://132941798