[CSApply] Allow marker existential to superclass conversions #75628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If existential is a protocol composition type where all of the
protocols are `@_marker`, narrowly allow coercion to its superclass
bound (if it matches). Both types have the same representation
which makes it okay.
This is only a problem in Swift 5 mode without strict concurrency
checks. In this mode `@preconcurrency` stripping happens
outside of the solver which means that no conversion restrictions
are recorded for members that got `& Sendable` stripped from
their types.
For example:
```swift
struct S {
@preconcurrency static let member: KeyPath<String, Int> & Sendable
}
func test() {
_ = S.member
}
```
Since `member` is `@preconcurrency` its type would get concurrency
annotations stripped, which includes `& Sendable` which means that
the solver uses `KeyPath<String, Int>` type for the reference and
not the original `KeyPath<String, Int> & Sendable`, this is a problem
for `ExprRewritter::adjustTypeForDeclReference` because conversion
between existential and its superclass bound requires a constraint
restriction which won't be available in this case.
Resolves: rdar://132700409
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Aug 1, 2024
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If existential is a protocol composition type where all of the protocols are
@_marker, narrowly allow coercion to its superclass bound (if it matches). Both types have the same representation which makes it okay.This is only a problem in Swift 5 mode without strict concurrency checks. In this mode
@preconcurrencystripping happens outside of the solver which means that no conversion restrictions are recorded for members that got& Sendablestripped from their types.For example:
Since
memberis@preconcurrencyits type would get concurrency annotations stripped, which includes& Sendablewhich means that the solver usesKeyPath<String, Int>type for the reference and not the originalKeyPath<String, Int> & Sendable, this is a problem forExprRewritter::adjustTypeForDeclReferencebecause conversion between existential and its superclass bound requires a constraint restriction which won't be available in this case.Resolves: rdar://132700409