[clang importer] The default apinotes path can be in the Platform's S… #75630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DK instead of runtime resource dir Swift platforms like Android (on a windows host) uses an SDK that's split for compiler's resource directory, and the apinote files like std.apinotes and posix_filesystem.apinotes are located in the SDK. This change thus makes the clang importer check to see if the api notes are located in the runtime resource directory, or the SDK
hyp
requested review from
zoecarver,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
will add a test too. |
compnerd
reviewed
Aug 1, 2024
| llvm::sys::path::get_separator() + | ||
| "apinotes").str(); | ||
| auto vfs = ctx.SourceMgr.getFileSystem(); | ||
| if (!vfs->exists(apiNotesPath)) { |
There was a problem hiding this comment.
If the path exists, I think that is okay, and we should just be doing a second additional path.
|
Seems the same as #75635? |
|
closing in favor of @compnerd 's PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DK instead of runtime resource dir
Swift platforms like Android (on a windows host) uses an SDK that's split from compiler's resource directory, and the apinote files like std.apinotes and posix_filesystem.apinotes are located in the SDK. This change thus makes the clang importer check to see if the api notes are located in the runtime resource directory, or in the SDK.