Skip to content

Revert "AST: Make absence of discriminator into a fatal error" #75638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

Revert "AST: Make absence of discriminator into a fatal error" #75638

merged 1 commit into from
Aug 2, 2024

Conversation

hborla
Copy link
Member

@hborla hborla commented Aug 1, 2024

  • Explanation: This assertion-turned-fatal-error tripped up some existing code that we haven't been able to reproduce locally.
  • Scope: This issue only seems to impact some applications of freestanding macros that accept closures.
  • Issues: rdar://130229431
  • Original PRs: N/A; we're keeping this change on main.
  • Risk: No additional risk compared to what's in the compiler today.
  • Testing: N/A
  • Reviewers: @slavapestov

@hborla hborla requested a review from a team as a code owner August 1, 2024 23:42
@hborla
Copy link
Member Author

hborla commented Aug 1, 2024

@swift-ci please test

@hborla hborla merged commit f6c311c into swiftlang:release/6.0 Aug 2, 2024
5 checks passed
@hborla hborla deleted the 6.0-revert-assertion branch August 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hborla @slavapestov @tbkka