Skip to content

Sema: Fix crash with SpecializeExpr around something that's not a type #75647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

slavapestov
Copy link
Contributor

Unfortunately the diagnostic is terrible.

Fixes #74858

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null check seems reasonable by I cannot reproduce the crash with example you checked in because DS doesn't exist, if I add DS it doesn't crash with the main compiler from yesterday.

@slavapestov
Copy link
Contributor Author

null check seems reasonable by I cannot reproduce the crash with example you checked in because DS doesn't exist, if I add DS it doesn't crash with the main compiler from yesterday.

I messed up the test because I first put it in test/decl/typealias/generic.swift. Oops, hang on

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@xedin
Copy link
Contributor

xedin commented Aug 2, 2024

No worries!

@slavapestov slavapestov merged commit fdfeb0e into swiftlang:main Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid use of variadic generics crashes compiler
2 participants