Optimizer: some improvements for alias analysis in several utilities #75689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have to take deinit effects into acount for a `destroy_value [dead_end]`. Such destroys are lowered to no-ops and will not call any deinit.
A small refactoring. NFC
Handle `apply` and `try_apply`. Also, improve test cases
…s base Makes e.g. alias analysis more precise in the early stage of the pass pipeline where addressor calls are not inlined, yet.
|
@swift-ci test |
|
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy_value [dead_end]inAliasAnalylsis.computeMemoryEffect: We don't have to take deinit effects into account for adestroy_value [dead_end]. Such destroys are lowered to no-ops and will not call any deinit.AccessBase.isLetinstead of duplicating the code inMemoryLocation.isLetValue.unchecked_addr_castinEscapeInfo.AccessUtils.