Revert "[Python] Use explicit imports" #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
added a commit
that referenced
this pull request
Dec 23, 2015
Revert "[Python] Use explicit imports"
|
@practicalswift Could you look into the failure and resubmit the PR with a fix? |
|
Splitting up the PR would help merge it in a little at a time--I'm particularly interested in removing the wildcards from |
|
@eeckstein Sorry about that! New PR submitted as #758. Split up as per @modocache:s request. |
gribozavr
added a commit
that referenced
this pull request
Dec 24, 2015
[Python] Use explicit imports (again) - split up to avoid pygments issue in #757
kateinoigakukun
pushed a commit
to kateinoigakukun/swift
that referenced
this pull request
Sep 7, 2020
[pull] swiftwasm-release/5.3 from release/5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #752
I got following build error on macos:
Exception occurred:
File "/Users/erik/proj/main-swift/swift/utils/pygments/swift.py", line 5, in
from pygments.lexer import (
ImportError: cannot import name Comment