Sema: Avoid emitting superfluous resilience diagnostics with MemberImportVisibility
#75766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mportVisibility`. When `MemberImportVisibility` is enabled, if the import that would bring a member declaration into scope is missing it is diagnosed as an error. The existing resilience diagnostics that would also diagnose the same problem in contexts that are visible in the module interface are therefore superflous with the feature enabled.
tshortli
force-pushed
the
superfluous-not-imported-here-diags
branch
from
85d0b19 to
7e1eac7
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
MemberImportVisibilityis enabled, if the import that would bring a member declaration into scope is missing it is diagnosed as an error. The existing resilience diagnostics that would also diagnose the same problem in contexts that are visible in the module interface are therefore superflous with the feature enabled.