[SILGen]: extend uninhabited parameter checks to self param
#75795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
commented
Aug 9, 2024
|
|
||
| // IMPORTANT: An unreachable block should be the last one in `emitProlog`, | ||
| // since it is a terminator and no instructions should be insterted after it. | ||
| if (selfParam) |
There was a problem hiding this comment.
with this change, at least one part of the standard library now emits a warning when built – the Never conformance to Identifiable. should that be changed? i think if this change is also merged, then the implementation could perhaps just be removed.
|
@jckarter when (if?) you have time, do you have any thoughts on the approach taken here? |
SILGenProlog contains logic to emit an unreachable location if a function contains a structurally uninhabited parameter. This change extends this logic to include the `self` parameter, so instance members of structurally uninhabited types will produce the same diagnostics and have the same SIL emission behavior.
jamieQ
force-pushed
the
uninhabited-self
branch
from
b90d8e6 to
e83970c
Compare
|
@jckarter – any chance you've had time to consider this? if not, is there someone else you'd recommend i try to involve for a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILGenProlog contains logic to emit an unreachable location if a function contains a structurally uninhabited parameter. This change extends this logic to include the
selfparameter, so instance members of structurally uninhabited types will produce the same diagnostics and have the same SIL emission behavior.