[cxx-interop] Support operator[] with multiple parameters #75803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ only support multiparameter operator[] in C++23 and up. Change the code to protect such overloaded operators with a C++ language mode check. rdar://133539699
egorzhdan
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Awesome, thanks!
I'm pretty sure on the forward interop side we would fail to import a C++ subscript with multiple parameters, but that shouldn't block this PR, I think
swift/lib/ClangImporter/SwiftDeclSynthesizer.cpp
Lines 1683 to 1684 in 8137aed
|
@swift-ci please smoke test |
|
Thanks! I opened rdar://133541125 so we do not forget the forward interop case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ only support multiparameter operator[] in C++23 and up. Change the code to protect such overloaded operators with a C++ language mode check.
rdar://133539699