Skip to content

Fix debug info in DeadObjectElimination in OSSA #75807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2024
Merged

Fix debug info in DeadObjectElimination in OSSA #75807

merged 1 commit into from
Aug 10, 2024

Conversation

meg-gupta
Copy link
Contributor

Move debug_value insertion before destroy_value insertion.

@meg-gupta
Fix debug info in DeadObjectElimination in OSSA
f71ab17 
Move debug_value insertion before destroy_value insertion.
@meg-gupta meg-gupta requested a review from eeckstein as a code owner August 9, 2024 17:11
@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta meg-gupta merged commit 920c560 into swiftlang:main Aug 10, 2024
3 checks passed
atrick
atrick reviewed Aug 11, 2024
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be a comment about why salvageDebugInfo needs to run at that point. It looks to me like it should run after all the optimization bailouts instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick left review comments

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@nate-chandler nate-chandler Awaiting requested review from nate-chandler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meg-gupta @atrick