Skip to content

Enable swift-foundation tests on Windows in toolchain builds #75811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmschonfeld
Copy link
Contributor

This enables swift-foundation tests to run in Windows toolchain builds. swift-corelibs-foundation tests are still disabled since the SwiftPM package does not yet build for Windows (we still need it to be able to correctly find libxml/curl dependencies)

@jmschonfeld
Copy link
Contributor Author

@swift-ci please smoke test

@jmschonfeld jmschonfeld marked this pull request as ready for review August 10, 2024 01:44
@jmschonfeld jmschonfeld requested a review from compnerd as a code owner August 10, 2024 01:44
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, some coverage is better than none.

@jmschonfeld jmschonfeld merged commit 36dee56 into swiftlang:main Aug 12, 2024
3 checks passed
@jmschonfeld jmschonfeld deleted the windows/enable-swift-foundation-tests branch August 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants