[6.0][region-isolation] Move logging in front of NDEBUG to make it easier to triage with no asserts compilers #75829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
This change is not targeting 6.0. I've converted this to a draft until we have a |
…ts builds. This will just help me to more quickly triage without needing to compile an asserts compiler. (cherry picked from commit 1fbc930)
…serts but just print out NOASSERTS instead of a debug id. (cherry picked from commit 2e08d61)
…rint}ID are in front of NDEBUG. (cherry picked from commit 226e97a)
…titionUtils.h -> RegionIsolation.h These do not specifically have to do with PartitionUtils... they are really logging options for the whole infrastructure, so it makes sense to have them in the a different file. (cherry picked from commit b477433)
…d the emitted error when triaging code. Just trying to improve my triaging speed by making it easier to triage. (cherry picked from commit a36b374)
gottesmm
force-pushed
the
release/6.0-make-debugging-easier
branch
from
0f09485 to
36ec99a
Compare
|
@swift-ci test |
|
Added a little more logging commits from main that make it quicker to triage. |
|
Didn't need this in the end. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: [region-isolation] Move logging in front of NDEBUG to make it easier to triage with no asserts compilers
This is just an attempt to make it easier to triage reported issues from no-asserts compilers. Today we compile those out, so I need to always compile an asserts compiler to do a basic triage. By moving this in front of NDEBUG, we ensure that we can enable this logging in no-asserts compilers.
Radars:
Original PRs:
Risk: Low. This just adds a new macro instead of LLVM_DEBUG that enables/disables the debugging error msgs in the same manner except controlled by a different command line option that is available when asserts are disabled.