Skip to content

[SymbolGraphGen] don't drop underscored protocol implementation symbols #75848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://133086270

Consider the following Swift code:

public protocol _HiddenProtocol {
    associatedtype T
}

public class MyClass: _HiddenProtocol {
    public struct T {}
}

When using SymbolGraphGen with the -skip-protocol-implementations flag, the type MyClass.T is hidden from the symbol graph, even though the protocol it's implementing is also hidden. This PR changes the -skip-protocol-implementations code to check whether the protocol being implemented has an underscored name before dropping the implementation symbol from the symbol graph.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus QuietMisdreavus force-pushed the QuietMisdreavus/underscored-protocol-implementation branch from 450cba7 to f53b2e4 Compare August 15, 2024 18:15
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus QuietMisdreavus enabled auto-merge (squash) August 15, 2024 18:15
@QuietMisdreavus QuietMisdreavus merged commit bafe819 into main Aug 15, 2024
3 checks passed
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/underscored-protocol-implementation branch August 15, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants