[SymbolGraphGen] don't drop underscored protocol implementation symbols #75848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://133086270
Consider the following Swift code:
When using SymbolGraphGen with the
-skip-protocol-implementations
flag, the typeMyClass.T
is hidden from the symbol graph, even though the protocol it's implementing is also hidden. This PR changes the-skip-protocol-implementations
code to check whether the protocol being implemented has an underscored name before dropping the implementation symbol from the symbol graph.