[Sema] Remove @unknown default requirement for package enums. #75872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
nkcsgexi
approved these changes
Aug 13, 2024
`@unknown default` in switch statements are required for resilient enums since they might be modified with new fields in the future and modules defining the enums are generally not built together with the consuming modules. However, if the modules are in the same package, they are required to be built together, thus the requirement for `@unknown default` can be skipped. This PR removes the need for that, enabling less boilerplate. Note this change only impacts typecheck and not SIL gen. Resolves rdar://130015149.
elsh
force-pushed
the
elsh/pkg-switch-enum
branch
from
8341e4b to
fadf6ec
Compare
|
@swift-ci smoke test |
|
pending #75745 as new test covers interface flag related changes. |
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test linux |
1 similar comment
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@unknown defaultin switch statements are required for resilient enums since they might be modified with new fields in the future and modules defining the enums are generally not built together with the consuming modules.However, if the modules are in the same package, they are required to be built together, thus the requirement for
@unknown defaultcan be skipped. This PR removes the need for that, enabling less boilerplate. Note this change only impacts typecheck and not SIL gen.Resolves rdar://130015149.