Skip to content

CrossModuleOptimization: serialized witness tables in embedded mode #75987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein commented Aug 20, 2024

This is needed so that client modules can de-virtualize witness method calls.

Fixes a false "cannot use a value of protocol type in embedded Swift" error.
rdar://133993657

@eeckstein eeckstein requested a review from jckarter as a code owner August 20, 2024 16:47
@eeckstein eeckstein requested review from kubamracek and elsh and removed request for jckarter August 20, 2024 16:48
@eeckstein
Copy link
Contributor Author

@swift-ci test

This is needed so that client modules can de-virtualize witness method calls.

Fixes a false "cannot use a value of protocol type in embedded Swift" error.
rdar://133993657
@eeckstein eeckstein force-pushed the fix-embedded-errors branch from e048c21 to 44d85c1 Compare August 20, 2024 18:32
@eeckstein eeckstein changed the title embedded: Fix two wrong "cannot use a value of protocol type in embedded Swift" errors CrossModuleOptimization: serialized witness tables in embedded mode Aug 20, 2024
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein eeckstein merged commit 011c127 into swiftlang:main Aug 21, 2024
5 checks passed
@eeckstein eeckstein deleted the fix-embedded-errors branch August 21, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants