Fix IRGen abi_v7k test case #7604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci test |
|
@swiftix Can you review this? This is a fix for a test case on armv7k. LLVM and our code generation has changed since this last tested successfully (for example we have change from i1 to i8 in IRGen). |
|
@aschwaighofer LGTM |
|
@swiftix Thank you! |
|
• Explanation: Fix IRGen abi_v7k test case. The generated assembly code has changed since this was last tested (llvm changed and IRGen code generation changed, we no longer lower to i1 but to i8). • Scope of Issue: This is a currently failing test case on the 3.1-branch. • Origination: Don’t know. • Risk: Low. This is only a change to a test case. • Testing: Swift CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://30584635