[DAH] Bail on pointer use if ignoring barriers. #76114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown uses of raw pointers should not result in bailing out when an address is lexical--the destroy of the address will already not be hoisted over any instructions which may access pointers. If the address is not lexical however (such as any address when lexical lifetimes are disabled), that rationale does not apply, so unknown uses of raw pointers must cause hoisting to bail. rdar://133969821
nate-chandler
force-pushed
the
rdar133969821_2
branch
from
f7b5e23 to
74c4bc9
Compare
|
@swift-ci please test |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown uses of raw pointers should not result in bailing out when an address is lexical--the destroy of the address will already not be hoisted over any instructions which may access pointers. If the address is not lexical however (such as any address when lexical lifetimes are disabled), that rationale does not apply, so unknown uses of raw pointers must cause hoisting to bail.
rdar://133969821