[CSBindings] Don't prioritize closures that are assigned to overloade… #76115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d members Constraint generation uses a special pattern while generating constraints for assignments to make sure that the source type is convertible to r-value type of the destination. `BindingSet::favoredOverDisjunction` needs to recognize this pattern, where disjunction type variable is bound early, and avoid prioritizing closure if it's connected to the "fixed type" of the disjunction or risk losing annotations associated with the member such as `@Sendable` or a global actor. Resolves: rdar://131524246
|
@swift-ci please test |
hamishknight
approved these changes
Aug 28, 2024
xedin
added a commit
to xedin/swift
that referenced
this pull request
Aug 30, 2024
…text Re-implements swiftlang#76115 in a simpler fashion now that we don't have to eagerly binding destination type on l-value.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Aug 30, 2024
…text Re-implements swiftlang#76115 in a simpler fashion now that we don't have to eagerly binding destination type on l-value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d members
Constraint generation uses a special pattern while generating constraints
for assignments to make sure that the source type is convertible to r-value
type of the destination.
BindingSet::favoredOverDisjunctionneeds to recognize this pattern,where disjunction type variable is bound early, and avoid prioritizing
closure if it's connected to the "fixed type" of the disjunction or risk
losing annotations associated with the member such as
@Sendableor a global actor.
Resolves: rdar://131524246