[AST] Account for non-user modules in isPrivateStdlibDecl
#76122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro,
QuietMisdreavus,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
This ensures we don't violate the invariant that a ModuleDecl isn't empty.
Consider both non-user and system modules when checking whether an underscored decl should be considered private. rdar://131854240
This better reflects what we're actually checking here.
hamishknight
force-pushed
the
platform-2
branch
from
bbad4c3 to
1cb0f8f
Compare
|
@swift-ci please test |
artemcm
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After landing #76057 I realized we were only checking modules marked system in
isPrivateStdlibDecl, meaning that it won't account for modules found in the SDK's parent platform directory. Change the check such that we allow either non-user or system modules to be considered, ensuring we e.g hide underscored members from platform modules in completion. Also rename the function toisPrivateSystemDeclto better reflect what it's checking.rdar://131854240