Skip to content

[test] Move test/attr/attr_availability_transitive_osx_appext.swift to fake version #76132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benlangmuir
Copy link
Contributor

Keep this test independent of the default deployment target by using a larger version number.

This is a follow-on to #76023 for a test that was recently changed

…o fake version

Keep this test independent of the default deployment target by using a
larger version number.
@benlangmuir benlangmuir requested a review from tshortli August 28, 2024 20:53
@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@tshortli
Copy link
Contributor

Probably not worth changing now, but did you try specifying an explicit -target that's low enough to keep the test otherwise written as-is? I don't think these tests have been authored with the intent of being sensitive to the default deployment target, they just happened to get away with it and the more surgical change might be to lower the deployment target instead.

@benlangmuir
Copy link
Contributor Author

Explicit target would work too, and some tests can only be handled that way (e.g. #76027 has a bunch), but the dominant style seemed to be using fake versions (e.g. #76023), so that's what I stuck with where it was possible. I don't really care either way, just trying to be consistent with the other availability tests.

@benlangmuir benlangmuir merged commit 27a5d62 into swiftlang:main Aug 29, 2024
5 checks passed
@benlangmuir benlangmuir deleted the test-fake-version-attr_availability_transitive_osx_appext branch August 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants