[ConstraintSystem] InferSendableFromCaptures: Mark unapplied operator references as @Sendable
#76136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently expressions like |
|
@swift-ci please test |
… references as `@Sendable` Both of these functions are single-apply instance members, even though their names could be compound the application is still a regular call with like `next(isolation: ...)` vs. `next(isolation:)(...)` it would have to be for a "compound" application. Operator references don't have a base type and could be found via unqualified lookup, `adjustFunctionTypeForConcurrency` should handle them specifically. Resolves: rdar://131321053
…` for for-in loops
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…Levels` to detect partial applications We used to detect partial applications based on member locators and parent expressions, but using function reference kind + check to see if self is applied is such simpler and hits both uses of `isPartialApplication`.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hamishknight
approved these changes
Aug 31, 2024
…ly applied instance methods on non-Sendable base
In situations like:
```
class A {
func test() {}
}
```
Fully uncurried function type should be @sendable but inner method
cannot be because it captures a non-Sendable type `A` when applied.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hamishknight
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator references don't have a base type and could be found via
unqualified lookup,
adjustFunctionTypeForConcurrencyshould handlethem specifically.
Resolves: rdar://131321053