[cxx-interop] Do not export enums with indirect associated values #76167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not support any sort of indirect enums yet, the code gets into an infinite recursion. Let's skip exporting these types to C++ for now until proper support is implemented. rdar://134852756
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Aug 30, 2024
Xazax-hun
added a commit
that referenced
this pull request
Sep 2, 2024
Explanation: Indirect enum cases can trigger infinite recursion. This PR stops attempting to export them to C++. Scope: C++ reverse interop. Risk: Low, we skip the problematic pattern. Testing: Regression test added. Issue: rdar://134852756 Reviewer: @egorzhdan Original PR: #76167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not support any sort of indirect enums yet, the code gets into an infinite recursion. Let's skip exporting these types to C++ for now until proper support is implemented.
rdar://134852756