[cxx-interop] Do not attempt to export read accessors to C++ #76170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggers a crash. Unfortunately, adding support is not that straightforward so skipping these accessors for now. rdar://134425834
|
@swift-ci please smoke test |
egorzhdan
reviewed
Aug 30, 2024
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you please also add a test where a Swift subscript has both get and _read accessors? I think we would want the get accessor to be used in that case, right?
There was a problem hiding this comment.
I tried adding both and got this error:
error: subscript cannot provide both a 'read' accessor and a getter
There was a problem hiding this comment.
Ah alright, I thought that is allowed, my bad
egorzhdan
approved these changes
Aug 30, 2024
Xazax-hun
added a commit
that referenced
this pull request
Sep 2, 2024
The reverse interop code assumed that there is always a get accessor for subscript which is not always the case. This PR prevents the crash by not exporting subscript when get accessor is not availableA. Scope: C++ reverse interop. Risk: Low, we just skip problematic operators. Testing: Regression test added. Issue: rdar://134425834 Reviewer: @egorzhdan Original PR: #76170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers a crash. Unfortunately, adding support is not that straightforward so skipping these accessors for now.
rdar://134425834