Skip to content

Add comparable conformance for C++ strings #76223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add comparable conformance for C++ strings #76223

merged 1 commit into from
Sep 4, 2024

Conversation

ishon19
Copy link
Contributor

@ishon19 ishon19 commented Sep 3, 2024

This PR adds Comparable conformance for C++ strings.

Fixes #76220

egorzhdan
egorzhdan reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ishon19 for this PR.
Could you please also add tests for the comparison between strings to the existing test file for std::string (test/Interop/Cxx/stdlib/use-std-string.swift)?

@ishon19
Copy link
Contributor Author

ishon19 commented Sep 3, 2024

Thanks @ishon19 for this PR. Could you please also add tests for the comparison between strings to the existing test file for std::string (test/Interop/Cxx/stdlib/use-std-string.swift)?

Sure, working on it!

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 3, 2024
@ishon19 ishon19 changed the title feat: add comparable conformance for C++ strings Add comparable conformance for C++ strings Sep 3, 2024
@ishon19 ishon19 requested a review from egorzhdan September 3, 2024 16:14
egorzhdan
egorzhdan reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I only have one comment on the implementation.

On a separate note, could you please also squash the two commits into a single commit?

@ishon19 ishon19 force-pushed the 76220-string-should-conform-to-comparable branch from 83d69e2 to 49d9067 Compare September 3, 2024 17:51
@ishon19 ishon19 requested a review from egorzhdan September 3, 2024 17:53
@ishon19
Copy link
Contributor Author

ishon19 commented Sep 3, 2024

This is looking great! I only have one comment on the implementation.

On a separate note, could you please also squash the two commits into a single commit?

Thanks @egorzhdan! Sure, merged them all in a single commit now.

@egorzhdan
Copy link
Contributor

@swift-ci please test

egorzhdan
egorzhdan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@egorzhdan egorzhdan merged commit 03abb1f into swiftlang:main Sep 4, 2024
5 checks passed
@ishon19
Copy link
Contributor Author

ishon19 commented Sep 4, 2024

LGTM, thanks!

Thanks for the review @egorzhdan! :)

egorzhdan added a commit that referenced this pull request Sep 6, 2024
@egorzhdan
[cxx-interop] Add a MutableCollection test that relies on `std::str…
dd78e3b 
…ing` being `Comparable`

This is possible after #76223.
@egorzhdan egorzhdan mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ std::string should conform to Comparable in Swift
2 participants
@ishon19 @egorzhdan