[cxx-interop] fix a clang assertion when synthesizing instance to sta… #76235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyp
requested review from
zoecarver,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
…tic member call for operator () A specific static operator () in MSVC's STL triggers this assertion in clang when buidling CxxStdlib: Assertion failed: isInstance() && "No 'this' for static methods!", file S:\SourceCache\llvm-project\clang\lib\AST\DeclCXX.cpp, line 2544 When the return statement is being constructed using clang sema in Swift's function synthesis code. This change avoids using member call expression for a call to static operator (), and instead performs a direct call, which closer matches what Clang's semas typechecker expects, and the default Clang's parsing behavior as well. This fixes the windows toolchain build with MSVC.
hyp
force-pushed
the
eng/fix-operator-call-synt
branch
from
a6451ed to
16b0c2a
Compare
|
@swift-ci please test |
compnerd
approved these changes
Sep 4, 2024
|
Hmm, I haven't seen this on the main branch before. Is this the same issue as something we've seen on rebranch: #75907? |
|
@swift-ci please test Windows platform |
|
@egorzhdan hmm, I think it is - and I do like your patch better. Could we cherry-pick that to main? |
|
Sure! I'll put up a PR within an hour |
|
@egorzhdan - could you please include the test case from this and ensure that still passes with your change? The one thing that I noticed is that you explicitly special cased |
egorzhdan
added a commit
that referenced
this pull request
Sep 4, 2024
Extracted from #76235. Co-authored-by: Alex Lorenz <[email protected]>
|
I just put up a PR: #76252 |
|
Thanks! |
|
Closing in favor of #76252 |
compnerd
pushed a commit
to compnerd/apple-swift
that referenced
this pull request
Sep 17, 2024
Extracted from swiftlang#76235. Co-authored-by: Alex Lorenz <[email protected]>
compnerd
pushed a commit
to compnerd/apple-swift
that referenced
this pull request
Sep 17, 2024
Extracted from swiftlang#76235. Co-authored-by: Alex Lorenz <[email protected]>
compnerd
pushed a commit
to compnerd/apple-swift
that referenced
this pull request
Sep 20, 2024
Extracted from swiftlang#76235. Co-authored-by: Alex Lorenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tic member call for operator ()
A specific static operator () in MSVC's STL triggers this assertion in clang when buidling CxxStdlib: Assertion failed: isInstance() && "No 'this' for static methods!", file S:\SourceCache\llvm-project\clang\lib\AST\DeclCXX.cpp, line 2544 When the return statement is being constructed using clang sema in Swift's function synthesis code.
This change avoids using member call expression for a call to static operator (), and instead performs a direct call, which closer matches what Clang's semas typechecker expects, and the default Clang's parsing behavior as well.
This fixes the windows toolchain build with MSVC.