Skip to content

[6.0] Add missed case to AssignAddressToDef. (#72617) #76258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

@aschwaighofer aschwaighofer commented Sep 4, 2024

Fixes a crash in asserts compiler toolchains.

Fixes #71744
Cherry-picked from a63078f

Description: Fixes a missing case to large types reg2mem. Without adding this case asserts compiler will complain and cause the compiler to crash.

Risk: Low. This should merely be a slightly more optimized code that we would have generated without an asserts compiler where we are fallback to a solution that loads and stores back to memory.

Scope: Fixes a compiler crasher in asserts toolchains.

Testing: Regression test added.

rdar://135227988
Issue #71744

@aschwaighofer aschwaighofer requested a review from a team as a code owner September 4, 2024 17:33
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@DougGregor
Copy link
Member

This has been subsumed by #76457

@DougGregor DougGregor closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants