[android] build libxml2 and curl with -fPIC on Windows #76262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets `CMAKE_POSITION_INDEPENDENT_CODE=YES` when building libxml2 and curl. This causes `-fPIC` to be passed to clang when compiling, which is required for the i686 Android build to succeed. This change makes `build.ps1` consistent with the Python build files swift_build_support\products\libxml2.py and swift_build_support\products\curl.py, which already define this cmake property. It is already propertly set for zlib in both locations.
hyp
approved these changes
Sep 4, 2024
compnerd
approved these changes
Sep 4, 2024
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Defines
CMAKE_POSITION_INDEPENDENT_CODE=YESwhen building libxml2 and curl on Windows withbuild.ps1. Defining this property makesbuild.psconsistent with the Python build scriptsswift_build_support\products\libxml2.pyandswift_build_support\products\curl.py.Problem Details
Android i686/x86 binaries fail to link against libraries compiled without
-fPIC.Validation
Successfully built swift toolchain locally with the following command on Windows:
This command previously failed linking with i686 libcurl due to not being compiled with
-fPIC.