[cxx-interop] Teach importer to interpret lifetimebound annotations #76311
Conversation
Xazax-hun
force-pushed
the
gaborh/import-lifetimebound
branch
2 times, most recently
from
c349cab to
00965c2
Compare
|
@swift-ci please smoke test |
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
hborla,
slavapestov and
xedin
as code owners
| } | ||
|
|
||
| //--- test.swift | ||
|
|
There was a problem hiding this comment.
Could you please add a module interface test that would check that the Swift lifetime attributes are printed in the generated interface for a C++ module?
See test/Interop/Cxx/class/access-specifiers-module-interface.swift for example
There was a problem hiding this comment.
Unfortunately, the Swift lifetimes are not supported by the module printer yet as there is no official/final syntax for it. That being said, I added checks like that because it is still useful to see what parameters are imported as borrowing. Let me know if that looks good.
There was a problem hiding this comment.
@meg-gupta is planning to add @lifetime() annotations to the module printer.
rdar://130342167 ([nonescapable] add .swiftinterface support for lifetime dependence)
There was a problem hiding this comment.
You can write an -emit-sil test like test/SIL/lifetime_dependence_buffer_view_test.swift to ensure that the SIL representation has _scope/ _inherit in the interim.
There was a problem hiding this comment.
A slightly unrelated comment: I might be missing something but lifetime_dependence_buffer_view_test.swift does not seem to invoke FileCheck? Is that intentional, or a bug?
There was a problem hiding this comment.
I updated the test to check the SIL.
There was a problem hiding this comment.
Thanks. I'll fix lifetime_dependence_buffer_view_test.swift to include FileCheck!
Xazax-hun
force-pushed
the
gaborh/import-lifetimebound
branch
from
00965c2 to
a810bea
Compare
|
@swift-ci please smoke test |
|
This all looks reasonable to me. |
Xazax-hun
force-pushed
the
gaborh/import-lifetimebound
branch
2 times, most recently
from
5e317ec to
beddb76
Compare
The lifetimebound annotations are now imported as lifetime dependencies. This works for basic cases but there are still some parts missing: * Support lifeitmebound annotations on constructors * A way to represent immortal/static lifetimes on the C++ side
Xazax-hun
force-pushed
the
gaborh/import-lifetimebound
branch
from
beddb76 to
16e012b
Compare
|
@swift-ci please smoke test |
The lifetimebound annotations are now imported as lifetime dependencies. This works for basic cases but there are still some parts missing:
rdar://135875896