[ASTPrinter] Fix missing operators in synthesized == impls printed by -print-ast.
#76331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`visitBinaryExpr` wasn't handling `UnresolvedDeclRefExpr` nodes, which the synthesized `==` implementation uses to compare fields/payloads. Also fixed the test that wasn't catching it since it also left out the operators.
allevato
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test |
|
@swift-ci please test macOS platform |
|
Working on clearing out my PR queue; I'm going to go ahead and merge this small fix. The current behavior is obviously wrong given that it was even encoded in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visitBinaryExprwasn't handlingUnresolvedDeclRefExprnodes, which the synthesized==implementation uses to compare fields/payloads. Also fixed the test that wasn't catching it since it also left out the operators.