Grammatical corrections for compound modifiers

[DePasqualeOrg]

The correct forms in English are "actor-isolated value" (hyphenate compound modifiers preceding nouns) and "is actor isolated" (don't hyphenate predicative compound modifiers).

https://stylemanual.com.au/contents/editing/compound-words/compound-modifiers-including-adjectives-and-adverbs

[tshortli]

@swift-ci please smoke test

[AnthonyLatsis]

The correct forms in English are "actor-isolated value" (hyphenate compound modifiers preceding nouns) and "is actor isolated" (don't hyphenate predicative compound modifiers).

Note: this accords with the Apple Style Guide.

[AnthonyLatsis]

Is this one not a predicate adjective?

[DePasqualeOrg]

Thanks, I've fixed this.

[xedin]

LGTM!

[xedin]

@swift-ci please test

[xedin]

cc @gottesmm

[xedin]

@swift-ci please test Windows platform

[DePasqualeOrg]

@xedin, this PR has been languishing for more than seven months and accumulated conflicts during that time, which I've now resolved. Can we move forward with this so that I don't have to resolve more conflicts in the future?

[AnthonyLatsis]

We don’t accept merge commits. Could you rebase your branch instead?

[AnthonyLatsis]

@swift-ci please smoke test macOS

[AnthonyLatsis]

Please squash them too.

[DePasqualeOrg]

Okay, I did that. But aren't both of those issues solved if you just do squash on merge?

[AnthonyLatsis]

@swift-ci please smoke test

[AnthonyLatsis]

Thanks for updating the history. I generally prefer not to squash on merge because then the original commit(s) are nowhere to be found except on GitHub. The occasional preference for the rebase method also makes recovering the right PR from a locally found commit harder in repositories like LLVM that tend to revert and reapply changes multiple times.