Skip to content

[test] Fix stdlib/RuntimeObjC.swift with newer deployment target #76355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

benlangmuir
Copy link
Contributor

This test stops working with deployment targets that no longer link @rpath/libswiftCoreGraphics.dylib when running on OSes that still require the CoreGraphics overlay. Explicitly link it to workaround.

rdar://135451615


Note: we previously applied this fix to stdlib/Reflection_objc.swift in #75914. I'm not sure why that

This test stops working with deployment targets that no longer link
@rpath/libswiftCoreGraphics.dylib when running on OSes that still
require the CoreGraphics overlay. Explicitly link it to workaround.

rdar://135451615
@benlangmuir
Copy link
Contributor Author

preset=buildbot_incremental,tools=RA,stdlib=RDA,test=macOS,type=device
@swift-ci please test with preset macOS

@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@benlangmuir benlangmuir marked this pull request as ready for review September 10, 2024 14:54
@benlangmuir benlangmuir requested a review from a team as a code owner September 10, 2024 14:54
@benlangmuir
Copy link
Contributor Author

@swift-ci please test macOS

@benlangmuir benlangmuir merged commit 28c6cc1 into swiftlang:main Sep 10, 2024
6 checks passed
@benlangmuir benlangmuir deleted the test-needs-cg branch September 10, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant