Skip to content

[Sema] Fixes for mutability handling in property wrappers #76357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

janbaig
Copy link
Contributor

@janbaig janbaig commented Sep 9, 2024

Prevents a crash when a parameter references an invalid property wrapper. The original code assumed that mutability information would always be available, but this assumption fails when the property wrapper is invalid

Resolves #65640

A test file is added to validation-tests as well

@xedin
Copy link
Contributor

xedin commented Sep 9, 2024

Thank you, @janbaig! I'll take a look ASAP!

@xedin
Copy link
Contributor

xedin commented Sep 9, 2024

@swift-ci please test

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xedin xedin merged commit 6236b25 into swiftlang:main Sep 10, 2024
5 checks passed
@janbaig janbaig deleted the issue-65640 branch October 25, 2024 17:28
@janbaig janbaig restored the issue-65640 branch November 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property-wrapped parameter crashes if property wrapper is missing wrappedValue
2 participants