Sema: Use internal import in fixits on public imports of private modules
#76386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic imports of a private module The error about a public import of a private module is raised when a library-level API module imports a library-level SPI module without a non-public access-level, `@_implementationOnly` attribute or `@_spiOnly` attribute. Update the fixit to insert an `internal` instead of a `@_implementationOnly`.
The test isn't mainly implementation-only anymore, have the name reflect that.
… now This was restricted to asserts to use Swift 6 mode.
|
@swift-ci Please smoke test |
artemcm
approved these changes
Sep 10, 2024
xymus
changed the title
internal import in fixits on a public imports of a private moduleinternal import in fixits on public imports of private modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error about a public import of a private module is raised when a library-level API module imports a library-level SPI module with a public access-level and no
@_implementationOnlyor@_spiOnlyattribute. Update the fixit to insert aninternalinstead of a@_implementationOnly, as internal imports are more reliable and encouraged over@_implementationOnly.