Sema: Reject unavailable associated types and observing accessors #76403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Source compatibility failures are all from a known issue. |
tshortli
force-pushed
the
availability-attr-diags
branch
from
61e735c to
d86ed15
Compare
tshortli
force-pushed
the
availability-attr-diags
branch
from
d86ed15 to
61e735c
Compare
Make it possible to share the diagnostics string for common case.
It should not be possible to mark an associated type declaration unavailable since doing so does not have an effect on how a conformance interacts with its associated types.
Marking an observer unavailable (or potentially unavailable) has no effect since the compiler emits calls to them unconditionally. Resolves rdar://80337141.
tshortli
force-pushed
the
availability-attr-diags
branch
from
61e735c to
21837e9
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the diagnostics for
@availableby rejecting the attribute whenever it would make either an associated type declaration or an observing accessor unavailable. The compiler does not consider the availability of these declarations when emitting code that uses them, so it is misleading to accept the@availableattribute on them.Resolves rdar://80337141.