Sema: Fix getPublicModuleName to look only at loaded modules
#76410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When onlyIfImported is true, we should return the public module name only when the public facing module is already imported. Replace the call to getModuleByIdentifier with getLoadedModule to prevent trigering loading that module. Also fix the test where the CHECK lined ended up matching itself from the diagnostics output.
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 11, 2024
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
onlyIfImportedis true, we should return the public module name only when the public facing module is already imported. Replace the call togetModuleByIdentifierwithgetLoadedModuleto prevent loading that module if it wasn't already loaded.Fix the broken test where the CHECK line was matching itself from the context shown by the Swift style diagnostics.
Fixup for #76269