Skip to content

[Basic] Remove llvm::JSON C bridging #76436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

[Basic] Remove llvm::JSON C bridging #76436

merged 1 commit into from
Sep 13, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 12, 2024

This was used for plugin message serialization, but it's migrated to SwiftCompilerPluginMessageHandling JSON.

@rintaro
[Basic] Remove llvm::JSON C bridging
d7303d1 
This was used for plugin message serialization, but it's migrated to
SwiftCompilerPluginMessageHandling JSON.
@rintaro rintaro requested a review from DougGregor as a code owner September 12, 2024 19:08
@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2024

@swift-ci Please smoke test

@rintaro rintaro requested a review from bnbarham September 12, 2024 23:23
DougGregor
DougGregor approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to convince me to remove dead code ;). Thank you!

@rintaro rintaro merged commit 1070279 into swiftlang:main Sep 13, 2024
3 checks passed
@rintaro rintaro deleted the basic-remove-llvmjson branch September 13, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor