Skip to content

[Concurrency] Add a debug variable that holds the current version of the concurrency library. #76437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Sep 12, 2024

This allows lldb to know which version of the internals layout it needs to use.

rdar://135886268

@mikeash
Copy link
Contributor Author

mikeash commented Sep 12, 2024

I tried to sprinkle the warning comment in a few different places to make it more likely to be noticed when one of us makes a change. Hopefully this is good coverage. I'm open to adding it in more places if anyone thinks that would be worthwhile.

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though ideally we wouldn't be changing ABI details anyway…

@mikeash
Copy link
Contributor Author

mikeash commented Sep 13, 2024

This would also cover various non-ABI internal details that the debugger might like to poke around in.

…the concurrency library.

This allows lldb to know which version of the internals layout it needs to use.

rdar://135886268
@mikeash mikeash force-pushed the concurrency-internal-version-variable branch from 4f43ce9 to bc6c027 Compare September 16, 2024 13:14
@mikeash mikeash requested a review from a team as a code owner September 16, 2024 13:14
@mikeash
Copy link
Contributor Author

mikeash commented Sep 16, 2024

test/abi/macOS/arm64/concurrency.swift and test/abi/macOS/x86_64/concurrency.swift needed an entry for this new symbol.

@mikeash
Copy link
Contributor Author

mikeash commented Sep 16, 2024

@swift-ci please smoke test

@mikeash mikeash enabled auto-merge September 16, 2024 13:14
@mikeash mikeash merged commit 9546d69 into swiftlang:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants