[CSSimplify] Delay inout type to pointer conversion until inout is sufficiently resolved
#76439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s sufficiently resolved If left-hand side of any conversion constraint is `inout` type and right is a pointer (or optional thereof), delay simplification until `inout` is at least partially structurally resolved (cannot be a type variable or dependent member) because eager simplification won't record all of the possible conversions.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
hamishknight
approved these changes
Sep 13, 2024
Allow inferring type of `inout` from a pointer type (or optional thereof) but delay the binding set because it might not be complete and object type of `inout` could also be an Array or C-style pointer type.
xedin
force-pushed
the
delay-implicit-pointer-conversions-for-unknown-inout
branch
from
05fbc70 to
279ef7d
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If left-hand side of any conversion constraint is
inouttypeand right is a pointer (or optional thereof), delay simplification
until
inoutis at least partially structurally resolved (cannotbe a type variable or dependent member) because eager simplification
won't record all of the possible conversions.
Allow inferring type of
inoutfrom a pointer type(or optional thereof) but delay the binding set because
it might not be complete and object type of
inoutcouldalso be an Array or C-style pointer type.