Skip to content

Disable a part of the Syntax unit tests under no-asserts. #7644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

jrose-apple
Copy link
Contributor

This is a quick fix to get the no-asserts bot back to passing; there may be a better way to clean up the code later.

This is a quick fix to get the no-asserts bot back to passing;
there may be a better way to clean up the code later.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test and merge

Copy link
Contributor

@bitjammer bitjammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I owe you one!

@jrose-apple
Copy link
Contributor Author

Hm. @shahmishal, the "and merge" part of this seems to have failed. Leaving for you to investigate in its broken state.

@jrose-apple
Copy link
Contributor Author

It looks like it eventually gave up. Merging by hand.

@jrose-apple jrose-apple merged commit b50f044 into swiftlang:master Feb 20, 2017
@jrose-apple jrose-apple deleted the assertions-required branch February 20, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants