[Outliner] Handle multiple consumes of a value. #76440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a single native value is bridged multiple times, it cannot be consumed without other changes. One option would be to copy it. The other option is taken here: sink the destroy of the native value to after the apply and have the outlined function take the value guaranteed. rdar://134198292
nate-chandler
force-pushed
the
rdar134198292
branch
from
3ac496c to
e7365aa
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
|
Source compat suite failures match failures in baseline ( https://ci.swift.org/job/swift-main-source-compat-suite/894/, https://ci.swift.org/job/swift-main-source-compat-suite-debug/894/ ) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single native value is bridged multiple times, it cannot be consumed without other changes. One option would be to copy it. The other option is taken here: sink the destroy of the native value to after the apply and have the outlined function take the value guaranteed.
rdar://134198292