[SourceKit] Format macro decl without crashing #76441
Conversation
vincentisambart
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
vincentisambart
changed the title
|
@swift-ci please smoke test |
| UIView() | ||
| } | ||
|
|
||
| // RUN: %sourcekitd-test -req=format -line=3 -length=1 %s >%t.response |
There was a problem hiding this comment.
If you write the response into %t.response you should also check its contents.
There was a problem hiding this comment.
Without the fix this test crashes, and indent-crashes.swift which seems to have a goal similar to this did write into %t.response without checking its content I thought it would be fine like this.
What do you think I should do?
- Do not write into
%t.response? - Write into
%t.responseand check the content? In that case should I change the test to be badly indented on purpose checking it properly gets into the expected shape?
Thanks
There was a problem hiding this comment.
I would unindent UIView() and then check that the response correctly indents UIView() to one indentation level.
There was a problem hiding this comment.
@ahoppen Thanks for the help! I just made the modifications you asked.
I also checked that running this test without my SourceKit changes still makes SourceKit crash and the test fail.
|
@swift-ci Please smoke test |
Resolves #70002
Fix SourceKit crash occurring when formatting a macro with both an available attribute and a trailing closure.
SourceKit's formatting code was expecting trailing closures to only be present on expressions (
Expr), but an available attribute on a macro makes it a declaration (Decl).I don't have much knowledge of how SourceKit's formatting works so I wouldn't be surprised if this was incomplete.