Enable NonEscapableTypes in standard library and make the feature suppressible #76455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
meg-gupta
force-pushed
the
enablestdlib
branch
from
37db2ea to
68bfc0d
Compare
|
@swift-ci test |
meg-gupta
requested review from
a team,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci smoke test windows platform |
|
If we're going to unconditionally turn this on for the stdlib, can we remove the |
DougGregor
approved these changes
Sep 16, 2024
tshortli
approved these changes
Sep 16, 2024
Comment on lines
+1
to
+2
| // RUN: %empty-directory(%t) | ||
| // RUN: %target-swift-emit-module-interface(%t.swiftinterface) %s -module-name Test -enable-experimental-feature NonescapableTypes |
There was a problem hiding this comment.
It looks like this file may be over-indented by one space on most of the lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the experimental feature
NonEscapableTypesby default in the standard library. It also makes it a "suppressible" feature so that uses of~Escapableand lifetime dependence are guarded by the feature flag.This change mostly follows what was done for
NonCopyableGenericsto make it a suppressible feature.